Issue 749: Reimport after adding new transitions causes new transitions to have #N/A peak areas

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:3
Milestone:20.2
Opened:2020-07-28 by Nick Shulman
Changed:2020-08-10 by Nick Shulman
Resolved:2020-08-10 by Nick Shulman
Resolution:Duplicate
Duplicate: 228
Closed:2020-08-10 by Nick Shulman
2020-07-28 Nick Shulman
Title»Reimport after adding new transitions causes new transitions to have #N/A peak areas
Assigned ToGuest»Nick Shulman
Type»Defect
Area»Skyline
Priority»3
Milestone»20.2
From this support request:
https://skyline.ms/announcements/home/support/thread.view?rowId=47889

If you do a "reimport" after adding new transitions to existing precursors with manually chosen peaks, then new transitions end up with peak areas that are null.

This happens because of this code in TransitionGroupDocNode.UpdateResults:
                                var results = nodeTran.HasResults ? nodeTran.Results[iResultOld] : default(ChromInfoList<TransitionChromInfo>);
                                if (results.IsEmpty)
                                    resultsCalc.AddTransitionChromInfo(iTran, null);
                                else
                                    resultsCalc.AddTransitionChromInfo(iTran, results.ToArray());

2020-08-10 Nick Shulman
resolve as Duplicate of 228
Statusopen»resolved

2020-08-10 Nick Shulman
close
Statusresolved»closed
Assigned ToNick Shulman»Guest