Issue 228: When re-importing, peak boundaries that have been manually set should recompute integration

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:2
Milestone:21.2
Opened:2013-04-06 by damodei
Changed:2021-11-29 by Nick Shulman
Resolved:2021-10-09 by Nick Shulman
Resolution:Fixed
Duplicates:749
Closed:2021-11-29 by Nick Shulman
2013-04-06 damodei
Title»When re-importing, peak boundaries that have been manually set should recompute integration
Assigned To»Brendan MacLean
Type»Defect
Area»Skyline
Priority»3
Milestone»2.1
If I import a file, manually set the integration boundaries for one of its chromatograms, then re-import the file, the chromatogram is updated but both the integration boundaries and the integrated area is preserved. Preserving the boundaries makes sense (so as not to destroy the user's manual work), but the area should be recalculated -- not doing this was problematic for me because I couldn't get the changes in the spectra (which occured because I changed settings before re-importing) to actually be reflected in the "Results Grid" or in any exported TSV.

2014-01-08 Brendan MacLean
Milestone2.1»2.6

2014-08-28 Brendan MacLean
Terrible, but we didn't manage to fix this for v2.6

2014-08-28 Brendan MacLean
Milestone2.6»3.1

2018-10-15 Brendan MacLean
Assigned ToBrendan MacLean»Nick Shulman
Priority3»2
Milestone3.1»4.3
Maybe if I reassign this to Nick and raise the priority it will get done.

2020-08-10 Nick Shulman
Milestone4.3»20.2

2020-08-10 Nick Shulman
Issue 749 marked as duplicate of this issue.
2020-10-05 Brendan MacLean
Assigned ToNick Shulman»Brendan MacLean

2020-10-05 Brendan MacLean
Milestone20.2»21.1

2021-08-27 Nick Shulman
Assigned ToBrendan MacLean»Nick Shulman
Milestone21.1»21.2
I am working on a fix for this in Pull Request #1739.

2021-10-09 Nick Shulman
resolve as Fixed
Statusopen»resolved
Assigned ToGuest»Nick Shulman
This was fixed in pull request #1739.
https://github.com/ProteoWizard/pwiz/pull/1739

2021-11-29 Nick Shulman
close
Statusresolved»closed
Assigned ToNick Shulman»Guest