Issue 785: Transition Settings - Ion Mobility - Fixed width value not saved when it is all that changes

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:2
Milestone:22.1
Opened:2021-04-02 14:20 by Brendan MacLean
Changed:2022-03-31 13:59 by Brian Pratt
Resolved:2022-03-31 13:59 by Brian Pratt
Resolution:Fixed
Closed:2022-03-31 13:59 by Brian Pratt
2021-04-02 14:20 Brendan MacLean
Title»Transition Settings - Ion Mobility - Fixed width value not saved when it is all that changes
Assigned To»Brian Pratt
Type»Defect
Area»Skyline
Priority»2
Milestone»21.1
Sue Abbatiello reported this one to me.

If you set up your Transition Settings - Ion Mobility tab to use Window type = "Fixed" and any value for Fixed width, and then OK.
The next time you bring up the form and change the Fixed width field, and only that field, and OK.

BUG: The change is not preserved, which you can see by bringing back the form. This is usually caused by adding a value to a class without adding it to the Equals() function so that during the TransitionSettingsUI.OkDialog() function when it tests to see if the existing instance Equals() the newly created instance, that turns out to be true, and so the code preserves the existing instance.

Sue reported being able to work around this by making an unrelated change, like unchecking the checkbox above, OK, and then return to find the value save, and recheck the checkbox.

Should be a simple fix.

2022-02-16 12:48 Brian Pratt
Milestone21.1»22.1

2022-03-31 13:59 Brian Pratt
resolve as Fixed
Statusopen»resolved
Fixed in commit 315270f

2022-03-31 13:59 Brian Pratt
close
Statusresolved»closed
Assigned ToBrian Pratt»Guest