Issue 955: "Associate Proteins" should not remove unmapped peptides from the document.

issues
Status:closed
Assigned To: Guest
Type: Defect
Area: Skyline
Priority: 2
Milestone: 23.1
Opened:2023-05-16 08:30 by Nick Shulman
Changed:2024-02-06 19:51 by Nick Shulman
Resolved:2023-12-13 09:03 by Matt Chambers
Resolution:Fixed
Closed:2024-02-06 19:51 by Nick Shulman
2023-05-16 08:30 Nick Shulman
Title»"Associate Proteins" should not remove unmapped peptides from the document.
Assigned To»Matt Chambers
Type»Defect
Area»Skyline
Priority»2
Milestone»23.1
"Refine > Associate Proteins" should not remove peptides from the document.
Unmapped peptides which were originally inside of a Peptide Group should remain in the same Peptide Group that they were in before.
Unmapped peptides which were originally inside of a Protein or Protein group should be moved to a Peptide Group called something like "Unmapped Peptides".

2023-07-18 13:17 Matt Chambers
What about decoy peptides?

2023-07-18 13:17 Matt Chambers
Notify»Brendan MacLean

2023-07-18 13:47 Nick Shulman
Decoy peptides should remain in the Peptide Group that they already belong to.
Since "Associate Proteins" does not result in any peptides being removed or added to the document, the decoy peptides that were already in the document are still valid decoys.

2023-07-18 13:50 Matt Chambers
I'm adding an option to keep peptides. Some users may want to discard unmapped peptides and it's simple to enable both. Also, it will always be possible for associate proteins to remove peptides by removing proteins due to the min peptide count filter (and that protein has some peptides that only occur in that protein).

What about regenerating decoys if a decoy list exists?

2023-12-13 09:03 Matt Chambers
resolve as Fixed
Statusopen»resolved
Assigned ToMatt Chambers»Nick Shulman

2024-02-06 19:51 Nick Shulman
close
Statusresolved»closed
Assigned ToNick Shulman»Guest