Issue 922: Edit > Find needs to use LongWaitDlg and support cancel

Status:resolved
Assigned To:Brendan MacLean
Type:Defect
Area:Skyline
Priority:3
Milestone:23.1
Opened:2022-11-07 20:47 by Brendan MacLean
Changed:2023-06-11 13:14 by Nick Shulman
Resolved:2023-06-11 13:14 by Nick Shulman
Resolution:Fixed
Closed:
2022-11-07 20:47 Brendan MacLean
Title»Edit > Find needs to use LongWaitDlg and support cancel
Assigned To»Brendan MacLean
Type»Defect
Area»Skyline
Priority»3
Milestone»23.1
We had a bit of a scare today at the ASMS fall workshop when Aaron used Edit > Find to find a peptide sequence in a very large DIA targets list, and it hung Skyline for minutes to the point that I was at his computer with him trying to help him use Task Manager to kill the instance of Skyline in which he had done this before it finally became responsive again.

Any potentially long-operation like this should be using LongWaitDlg, ideally with some kind of useful progress like how far through the entire document the search is so that if it has to traverse the entire document to report that the text cannot be found the user has some sense of how long it would take to get there, and it should support clicking the Cancel button to stop the search.

2022-11-07 20:47 Brendan MacLean
Assigned ToBrendan MacLean»Nick Shulman

2023-06-11 13:14 Nick Shulman
resolve as Fixed
Statusopen»resolved
Assigned ToNick Shulman»Brendan MacLean
Fixed in PR#2589 last month.