Issue 858: make "ImportPeptideSearch with the IMS filtering visible" a form view that can be shown in the SkylineTester Forms tab

issues
Status:resolved
Assigned To:Brian Pratt
Type:Defect
Area:Skyline
Priority:3
Milestone:22.1
Opened:2021-12-08 by Brian Pratt
Changed:2021-12-14 by Brendan MacLean
Resolved:2021-12-14 by Brendan MacLean
Resolution:Fixed
Closed:
2021-12-08 Brian Pratt
Title»make "ImportPeptideSearch with the IMS filtering visible" a form view that can be shown in the SkylineTester Forms tab
Assigned To»Brian Pratt
Type»Defect
Area»Skyline
Priority»3
Milestone»22.1
From GChat thread 12/8/2021

Brendan MacLean, 51 min
Is there a test that shows ImportPeptideSearch with the IMS filtering visible? I guess the diaPASEF tutorial. We should add that as a form view that can be shown in the SkylineTester - Forms tab.

Brian Pratt, 49 min
Unsure how to specify flavors of form views? I thought it was just class names and reflection?

Brendan MacLean, 43 min
I think I have it.

Brendan MacLean, 3 min
Check the ImportPeptideSearchDlg or PeptideSettingsUI, TransitionSettingsUI, ExportMethodDlg for how to do different views of a form by defining an IFormView class. We do it a lot, and you may just be forgetting how to do it.

Brian Pratt, 2 min
>> you may just be forgetting how to do it

no doubt

2021-12-08 Brian Pratt
Assigned ToBrian Pratt»Brendan MacLean
Sounds like Brendan already has the work done, assigning to him to close when he commits the changes.

2021-12-14 Brendan MacLean
resolve as Fixed
Statusopen»resolved
Assigned ToBrendan MacLean»Brian Pratt
Fixed in PRs 1890 and 1892