Issue 85: Results grid hangs trying to set annotations

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:1
Milestone:1.2
Opened:2011-09-18 by Brendan MacLean
Changed:2011-11-11 by Brendan MacLean
Resolved:2011-09-22 by Nick Shulman
Resolution:Fixed
Closed:2011-11-11 by Brendan MacLean
2011-09-18 Brendan MacLean
Title»Results grid hangs trying to set annotations
Assigned To»nicksh@u.washington.edu
Notify»mburgess@broadinstitute.org susana@broad.mit.edu bschilling@buckinstitute.org
Type»Defect
Area»Skyline
Priority»1
Milestone»1.2
Download the files brendanx@proteome.gs.washington.edu:data/Issues/20110918_MikeB_annotate/Study9_1_Site56C_annotation_test_091411.sky*
Open the Skyline document.
Select the first peptide.
Expand the peptide and select its light precursor.
Choose a signal quality annotation for the second row.
Select the second peptide.
Expand the peptide and select its light precursor.
Choose a signal quality annotation for the third row.

BUG: Skyline hangs.

2011-09-18 Brendan MacLean
Worth noting that there is no Skyline code on the stack when you break into the debugger. May need .NET debug symbols to solve this one.

2011-09-22 Nick Shulman
resolve as Fixed
Statusopen»resolved
Assigned Tonicksh@u.washington.edu»Brendan MacLean
This was a toughie. We get stuck in ControlContainer.UpdateFocusedControl. It's not clear to me why that happens.
I'm thinking that when the editing control on the grid disappears, focus on the form gets set to nowhere, and it looks like there a hang might be possible in ContainerControl.UpdateFocusedControl if "ActiveControl" and "FocusedControl" start out null going in there. But, the code there is pretty confusing so I'm not sure what's going on.

One thing I found that I could do to fix the problem is to add:
FindForm().ActiveControl = this;
to the end of DataGridViewEx.OnEnter.

It looks like this person on the web ran into the same issue, but they don't have any advice about what to do about it:
http://community.divelements.co.uk/cs/forums/t/5034.aspx

2011-09-22 Brendan MacLean
Thanks, Nick! This fix will be in the next Skyline-daily release.

2011-11-11 Brendan MacLean
close
Statusresolved»closed
Assigned ToBrendan MacLean»Guest