Issue 753: Value list annotations should not allow empty lists

issues
Status:open
Assigned To:Nick Shulman
Type:Defect
Area:Skyline
Priority:3
Milestone:21.2
Opened:2020-10-08 by Brendan MacLean
Changed:2021-11-30 by Brendan MacLean
Resolved:
Resolution:
Closed:
2020-10-08 Brendan MacLean
Title»Value list annotations should not allow empty lists
Assigned To»Nick Shulman
Type»Defect
Area»Skyline
Priority»3
Milestone»20.2
This caused confusion at the Skyline Online course. If I create a Value List annotation, I should get an error message if I don't supply any values in the value list, potentially if I don't supply at least 2 values, but a valueless value list is completely useless and confusing.

2020-10-09 Nick Shulman
resolve as Fixed
Statusopen»resolved
Assigned ToNick Shulman»Brendan MacLean
Fixed in Pull Request #1267

2021-11-30 Brendan MacLean
reopen
Statusresolved»open
Assigned ToBrendan MacLean»Nick Shulman
Milestone20.2»21.2
I decided to give you a bit more testing here, Nick. Kinda like I would have at Microsoft. I found 2 new issues:

1. Empty lines get counted as values despite being visually indistinguishable from an unset annotation which is also shown as an empty line.
2. Value lists have no problem with duplicate values despite it being impossible to distinguish.

I can enter any number of empty lines and they will get reproduced in the dropdown for choosing an annotation. And I can enter an number of say "X" lines and they also will get reproduced on the dropdown. We should either error in such cases or compact out the duplicates and empty lines (which are duplicates of the unset state).