Issue 746: Retention time alignment makes mouse act out of phase on aligned replicate graphs

issues
Status:resolved
Assigned To:matt.chambers42@gmail.com
Type:Defect
Area:Skyline
Priority:3
Milestone:20.2
Opened:2020-07-22 by matt.chambers42
Changed:2020-07-22 by Nick Shulman
Resolved:2020-07-22 by Nick Shulman
Resolution:Fixed
Closed:
2020-07-22 matt.chambers42
Title»Retention time alignment makes mouse act out of phase on aligned replicate graphs
Assigned ToGuest»Nick Shulman
Type»Defect
Area»Skyline
Priority»3
Milestone»20.2
This can be reproduced in the MS1 tutorial. I tested on master@b27502862a7045a5dc957d211ebe216cbbb91e51 . After importing results, click a peptide, align RT to one of the replicates, then observe the mouse behavior in the aligned replicate (the one whose RTs have been shifted). The mouse-over dot follows the mouse correctly, but clicking to view the scan puts the "currently viewed scan" dot in the wrong place. The effect is not extreme in this dataset because the RT alignment isn't large, but it is noticeable. The integration boundaries are also out of phase when dragging them in the aligned replicate (visible once you start dragging one, not just clicking it or mousing over).

I assign this to you Nick only because I expect you're more familiar with the RT alignment and graph code and may know offhand what would be causing this.

2020-07-22 Nick Shulman
I introduced this bug in March when I made a change to ChromGraphItem.GetValidPeakBoundaryTime.
It's using "displayTime" in a place where it's supposed to be using "measuredTime".
I'll fix this.

2020-07-22 Nick Shulman
resolve as Fixed
Statusopen»resolved
Assigned ToNick Shulman»matt.chambers42@gmail.com
Fix in pull request #1155.