Issue 682: Import peptide search from Start page differs from File > Import > Peptide Search

Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:2
Milestone:19.1
Opened:2019-09-24 21:37 by Brendan MacLean
Changed:2021-11-30 12:37 by Brendan MacLean
Resolved:2019-09-25 14:41 by Kaipo Tamura
Resolution:Fixed
Closed:2021-11-30 12:37 by Brendan MacLean
2019-09-24 21:37 Brendan MacLean
Title»Import peptide search from Start page differs from File > Import > Peptide Search
Assigned ToGuest»Kaipo
Type»Defect
Area»Skyline
Priority»2
Milestone»19.1
When you click one of the import peptide search options (DDA, DIA, PRM) on the Start page, the wizard appears with the Spectral Library tab showing the "Search files" list filling the entire bottom of the form without showing the "iRT standard peptides" dropdown or the "Include ambiguous matches" checkbox.

If you use File > Import > Peptide Search to get to the same form, then you get the group box with radio buttons allowing you to choose between the 3 options, and you also get the "iRT standard peptides" dropdown and the "Include ambiguous matches" checkbox.

These two controls should be available in both cases with only the radio buttons and group box coming and going.

If this is a relatively simple fix, it would be nice to get it into 19.1. Not sure when this got broken or if it ever worked, but it is unfortunate that the iRT standards are not offered to users to begin from the Start page, which I would expect to be more common than using File > Import > Peptide Search.

2019-09-25 09:05 Kaipo Tamura
Looks like some new controls got added to the form which broke it. Luckily I think we can fix it just by removing lines 580-585 from BuildPeptideSearchLibraryControl.cs. I'll test it and make a pull request.

2019-09-25 14:41 Kaipo Tamura
resolve as Fixed
Statusopen»resolved
Assigned ToKaipo»Brendan MacLean

2021-11-30 12:37 Brendan MacLean
close
Statusresolved»closed
Assigned ToBrendan MacLean»Guest