Issue 666: The "Add small molecule test nodes" checkbox on SkylineTester is obsolete and confusing, should be removed

issues
Status:resolved
Assigned To:Brian Pratt
Type:Defect
Area:Skyline
Priority:3
Milestone: 
Opened:2019-07-24 by Brian Pratt
Changed:2019-09-25 by Brian Pratt
Resolved:2019-09-25 by Brian Pratt
Resolution:Fixed
Closed:
2019-07-24 Brian Pratt
Title»The "Add small molecule test nodes" checkbox on SkylineTester is obsolete and confusing, should be removed
Assigned ToGuest»Brendan MacLean
Type»Defect
Area»Skyline
Priority»3

2019-07-24 Brendan MacLean
Assigned ToBrendan MacLean»Brian Pratt
Yep. Agreed. Go for it.

2019-07-25 Brian Pratt
The core issue is that not all recent tests are set up to anticipate this extra document node, so a new developer might be surprised when using this option by accident. We don't really need it anymore - we now have actual small molecule data we can work with.

2019-09-25 Brian Pratt
resolve as Fixed
Statusopen»resolved
fixed in SHA-1: 532ed586a0416b7ef32f4ca3daa5e47efb28edea

* Skyline: when we first started supporting non-peptide data we didn't … (#594)

Skyline: when we first started supporting non-peptide data we didn't have a lot of examples. So we devised a special test mode that can add a non-peptide node to any test document on the fly. We don't really use it any more since we now have actual examples and tests, so now it just serves to confuse new Skyline developers. Thus I'm tearing it out to de-cruft the code base.