Issue 528: Column header sort messes up peak scoring model training grid

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:3
Milestone:4.1
Opened:2017-06-28 by Brendan MacLean
Changed:2017-10-18 by Brendan MacLean
Resolved:2017-10-18 by Brendan MacLean
Resolution:Fixed
Closed:2017-10-18 by Brendan MacLean
2017-06-28 Brendan MacLean
Title»Column header sort messes up peak scoring model training grid
Assigned To»Nick Shulman
Type»Defect
Area»Skyline
Priority»3
Milestone»4.1
Edit TestPeakPickingTutorial and turn on PauseForScreenshots.
Run the test until you see a trained Edit Peak Scoring Model.
Click on the headers in the score calculator grid.

Result: Sorting messes up the correlation between formatting, enabling, etc. This grid just can't deal with sorting at the moment, but it is perfectly reasonable to want to be able to sort by contribution.

Thought maybe you could fix this one easily, Nick.

2017-06-28 Nick Shulman
Assigned ToNick Shulman»tobiasr
Can you fix this?
You can get to the EditPeakScoringDlg by going to:
Edit > Refine > Reintegrate
and choosing "Add".

It looks like what we need to do is handle the "ListChanged" event on "bindingPeakCalculators". In that event handler we should call "UpdateCalculatorGrid".
Also, UpdateCalculatorGrid needs to be changed. Currently it looks at "_peakScoringModel.Paramters.Weights[rowIndex]" which is not the right thing to look at once the grid is being sorted.
Instead, it should look at "PeakCalculatorWeights[rowIndex]".

2017-10-18 Brendan MacLean
resolve as Fixed
Statusopen»resolved
Assigned Totobiasr»Brendan MacLean
This got fixed a while ago.

2017-10-18 Brendan MacLean
close
Statusresolved»closed
Assigned ToBrendan MacLean»Guest