Issue 344: Exclude spectrum source files checkbox present in ImportResultsControl but not functional

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:2
Milestone:3.1
Opened:2014-09-26 by Brendan MacLean
Changed:2015-06-24 by Brendan MacLean
Resolved:2015-06-24 by Brendan MacLean
Resolution:Fixed
Closed:2015-06-24 by Brendan MacLean
2014-09-26 Brendan MacLean
Title»Exclude spectrum source files checkbox present in ImportResultsControl but not functional
Assigned To»kaipot@u.washington.edu
Type»Defect
Area»Skyline
Priority»2
Milestone»3.1
About a year ago in r4839, Kaipo added the checkbox cbExcludeSourceFiles to ImportResultsControl, but it is initialized invisible (as it should be) and then never referenced again in the code. I thought I had seen this working in code review, but then found it not working during practice for teaching a targeted proteomics course tutorial. Not sure what happened.

The checkbox should appear when we would otherwise suggest files with names that exactly match the source files in a spectral library, giving the user an opportunity to elect to not to use mzXML or mzML files that match but may not even contain MS1 spectra, and instead elect to use raw data files.

I started playing with this, but it is a little more involved than I had hoped. We would need to save the library source file names perhaps start to use the fact that the matching names data structure contains a list of possible matches, storing the ones we have found, and prioritizing based on the checkbox. We should show the checkbox when the highest priority file for any name matches a library source file name. Also, the first time the checkbox is checked, we should search the document path, and probably any other folder where we have a matching file.

Then we need a test that will ensure this stays working correctly.

2015-06-24 Brendan MacLean
resolve as Fixed
Statusopen»resolved
Assigned Tokaipot@u.washington.edu»Brendan MacLean
This has been fixed.

2015-06-24 Brendan MacLean
close
Statusresolved»closed
Assigned ToBrendan MacLean»Guest