Issue 300: Change encoding of filepaths in .skyd files from Default to UTF-8

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:3
Milestone:2.6
Opened:2014-02-04 by Vagisha
Changed:2014-05-21 by Brendan MacLean
Resolved:2014-05-21 by Brendan MacLean
Resolution:Fixed
Closed:2014-05-21 by Brendan MacLean
2014-02-04 Vagisha
Title»Change encoding of filepaths in .skyd files from Default to UTF-8
Assigned To»Vagisha
Type»Defect
Area»Skyline
Priority»3
Milestone»2.6
We cannot rely on default encoding to be the same on all systems. This can be a problem in Panorama if the encoding used to write the filepath is not the same as the default encoding on the JVM. Panorama compares file paths read from the .skyd file to the file paths for sample files to get the right chromatogram for a precursor result.


From Brendan:
I think we need to bump the SKYD format version number to change to UTF8. We should talk about whether we can do that before releasing v2.5 or we need to wait.

Then we should also talk about what we should do for decoding this path in SKYD 6 and earlier format. Probably safest is just to use whatever encoding is default for English (US).

2014-05-21 Brendan MacLean
resolve as Fixed
Statusopen»resolved
Assigned ToVagisha»Brendan MacLean
This has been committed.

2014-05-21 Brendan MacLean
close
Statusresolved»closed
Assigned ToBrendan MacLean»Guest