Issue 288: InvalidOperationException in AdlerChecksum.MakeForString if type filename into Import Results File Open Dialog

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:2
Milestone:2.5
Opened:2014-01-15 by Nick Shulman
Changed:2014-01-26 by Brendan MacLean
Resolved:2014-01-16 by Brian Pratt
Resolution:Fixed
Closed:2014-01-26 by Brendan MacLean
2014-01-15 Nick Shulman
Title»InvalidOperationException in AdlerChecksum.MakeForString if type filename into Import Results File Open Dialog
Assigned To»bspratt
Type»Defect
Area»Skyline
Priority»2
Milestone»2.5
https://skyline.gs.washington.edu/labkey/announcements/home/issues/exceptions/thread.view?rowId=7592

1. Open a Skyline document that has some data in it.
2. File>Import Results
3. In the Open Data Source dialog, navigate to a directory containing some files that you could import.
4. Type the name of one of the files in that directory into the text box on the Open Data Source dialog. Do not click on the file.
Result:
Eventually, InvalidOperationException thrown by AdlerChecksum.MakeForString

I think in OpenDataSourceDialog.Open() this line:
DataSources = new[] { sourcePathTextBox.Text };
should be changed to something like:
DataSources = new[] { Path.Combine(CurrentDirectory, sourcePathTextBox.Text) };

2014-01-16 Brian Pratt
resolve as Fixed
Statusopen»resolved
fixed in SVN 5558 - Manually repro'd using both actual filename without path and garbage characters. Wrote the fix, ran the same manual tests to good effect: actual filename now works, garbage characters just provoke the usual "please select a data source" message.

2014-01-26 Brendan MacLean
close
Statusresolved»closed
Assigned Tobspratt»Guest