Issue 233: Move from dictionary to array in pwiz.Skyline.Model.Results.ChromDataCollectorSet.ProcessExtractedSpectrum(Double, ExtractedSpectrum)

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:3
Milestone:2.5
Opened:2013-04-16 by Brendan MacLean
Changed:2014-01-08 by Brendan MacLean
Resolved:2014-01-08 by Brendan MacLean
Resolution:Fixed
Closed:2014-01-08 by Brendan MacLean
2013-04-16 Brendan MacLean
Title»Move from dictionary to array in pwiz.Skyline.Model.Results.ChromDataCollectorSet.ProcessExtractedSpectrum(Double, ExtractedSpectrum)
Assigned To»donmarsh@proteinms.net
Type»Defect
Area»Skyline
Priority»3
Milestone»2.1
For large full-scan filtering files like our current stress case, the read phase of chromatogram building currently spends around 50% of its time in pwiz.Skyline.Model.Results.ChromDataCollectorSet.ProcessExtractedSpectrum(Double, ExtractedSpectrum), with nearly 60% of that in Dictionary.TryGetValue(). Based on the work you did to convert from dictionary look-up to table look-up for the new chromatogram progress indicator, we should be able to make a similar change in ProcessExtractedSpectrum and reclaim nearly all of this time.

2013-08-09 Brendan MacLean
Milestone2.1»2.2

2014-01-08 Brendan MacLean
Milestone2.2»2.5
Is this still true? If so, move it to v2.6, and let's get it fixed. I think we fixed this for v2.1, though.

2014-01-08 Brendan MacLean
resolve as Fixed
Statusopen»resolved
Assigned Todonmarsh@proteinms.net»Brendan MacLean

2014-01-08 Brendan MacLean
close
Statusresolved»closed
Assigned ToBrendan MacLean»Guest