Issue 232: Improve chromatogram read performance for large full-scan files

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:3
Milestone:3.1
Opened:2013-04-16 by Brendan MacLean
Changed:2016-01-08 by Brendan MacLean
Resolved:2016-01-08 by Brendan MacLean
Resolution:Fixed
Closed:2016-01-08 by Brendan MacLean
2013-04-16 Brendan MacLean
Title»Improve chromatogram read performance for large full-scan files
Assigned To»donmarsh@proteinms.net
Type»Defect
Area»Skyline
Priority»3
Milestone»2.1
Adding mass error has nearly doubled the number of bytes written to disk in some large MS1 filtering cases, like the stress test we have been using. This is causing the ChromDataCollector class to fall behind the ChromCacheBuilder write thread for a pretty significant slowdown in the peak picking phase of chromatogram import. We should look into either using compression when writing these bytes to disk, or writing the mass errors as shorts instead of floats, as we do eventually in the .skyd file, or both.

2013-08-09 Brendan MacLean
Milestone2.1»2.2

2014-01-08 Brendan MacLean
Milestone2.2»2.6

2014-08-28 Brendan MacLean
Milestone2.6»3.1

2016-01-08 Brendan MacLean
resolve as Fixed
Statusopen»resolved
Assigned Todonmarsh@proteinms.net»Brendan MacLean
This is fixed by the new chromatogram spilling functionality.

2016-01-08 Brendan MacLean
close
Statusresolved»closed
Assigned ToBrendan MacLean»Guest