Issue 890: Audit log Skyline Version upgrade

issues
Status:open
Assigned To:Kaipo Tamura
Type:Defect
Area:Skyline
Priority:3
Milestone:22.1
Opened:2022-05-23 17:12 by Brendan MacLean
Changed:2022-05-23 17:12 by Brendan MacLean
Resolved:
Resolution:
Closed:
2022-05-23 17:12 Brendan MacLean
Title»Audit log Skyline Version upgrade
Assigned To»Kaipo
Notify»Nick Shulman;Josh Eckels
Type»Defect
Area»Skyline
Priority»3
Milestone»22.1
Looking at this audit log on Panorama with Josh and Wendy of LabKey

https://panoramaweb.org/Panorama%20Public/2022/UC%20Riverside%20Metabolomics%20Core%20-%20Karine%20Le%20Roch%20LAB/targetedms-showSkylineAuditLog.view?id=130746

We noticed that all of the audit log records have Format Version / Skyline Version "20.1.1.147- (64-Bit)" (customize the grid to see this field), but the version listed in the document summary is:

Skyline-daily (64-bit) 21.2.1.377 (c69303671)

I explained to Josh that until very recently, whatever version of Skyline did the upload to Panorama forced a save and that would be the version listed at the top level by Panorama. Josh pointed out that it seemed like the audit log should contain this operation.

That is, when we open a Skyline document from an older version, we add an audit log entry for that, so that if the user saves the document, we have a record of this "upgrade" operation. This is especially true, if the older version has a different Skyline document format version. So, maybe we wouldn't need to do it between two Skyline-daily versions, but definitely, switching between two major versions would cause an audit log entry to make it clearer why the upper-level Skyline document versions differ from everything else in the audit log in a case like this one.