Title | | » | revisit changes around ReSharper 2019.1 issues with false null check warnings |
Assigned To | Guest | » | Brian Pratt |
Type | | » | Todo |
Area | | » | Skyline |
Priority | | » | 3 |
Milestone | | » | 19.2 |
We had to insert several redundant comments like this:
if (library != null)
{
// (ReSharper 2019.1 seems not to notice the check that's already here)
// ReSharper disable PossibleNullReferenceException
foreach (var pooledStream in library.ReadStreams)
// ReSharper restore PossibleNullReferenceException
pooledStream.CloseStream();
}
we should take them back out again if ReSharper fixes this problem.
Note that this needs to be OK both on Team City and local systems, and it seems that the version on Team City isn't quite the same. For example, this worked locally
if (library != null)
{
// ReSharper disable once PossibleNullReferenceException (ReSharper 2019.1 seems not to notice the check that's already here)
foreach (var pooledStream in library.ReadStreams)
pooledStream.CloseStream();
}
but on TC it seemed to not understand the structured comment with something tacked onto the end.