Issue 642: BiblioSpec unicode filepath support

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:3
Milestone:4.3
Opened:2019-03-27 09:43 by Matt Chambers
Changed:2022-03-01 13:05 by Matt Chambers
Resolved:2019-04-25 09:28 by Matt Chambers
Resolution:Fixed
Closed:2022-03-01 13:05 by Matt Chambers
2019-03-27 09:43 Matt Chambers
Title»BiblioSpec unicode filepath support
Assigned ToGuest»matt.chambers42@gmail.com
Notify»Brendan MacLean
Type»Defect
Area»Skyline
Priority»3
Milestone»4.3
For i18n support, all the file handling functions would need to be updated to either use narrow strings with UTF-8 encoding, or wide strings with UTF-16 encoding. Narrow with UTF-8 is what we did to add i18n support for core proteowizard (using boost nowide to convert the UTF-8 to WCHAR when calling Windows API functions), but our file handling functions are somewhat more centralized there than in BiblioSpec. So any fopen, stdin, fstream::open, etc calls need to be switched to make sure they would use boost::nowide (and possibly refactored if boost::nowide doesn't support the particular overload or function BiblioSpec currently uses). Boost::nowide also provides UTF-8 versions of cin/cout so the standard input could support UTF-8 easily as well.

2019-04-25 09:28 Matt Chambers
resolve as Fixed
Statusopen»resolved
Fixed with PR #500

2022-03-01 13:05 Matt Chambers
close
Statusresolved»closed
Assigned Tomatt.chambers42@gmail.com»Guest