Issue 237: Popup pick lists can end up inserting nodes that are out of sync with the settings

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Skyline
Priority:3
Milestone: 
Opened:2013-05-09 11:35 by Brendan MacLean
Changed:2026-01-06 12:58 by Brendan MacLean
Resolved:2026-01-06 12:58 by Brendan MacLean
Resolution:GitHub Move
Closed:2026-01-06 12:59 by Brendan MacLean
2013-05-09 11:35 Brendan MacLean
Title»Popup pick lists can end up inserting nodes that are out of sync with the settings
Assigned To»Brendan MacLean
Type»Defect
Area»Skyline
Priority»3
Milestone»2.1
The pop-up pick lists calculate their DocNodes when the pick list is shown, and then insert them into the document later unchanged. This means that if the document changes between those times, e.g. a library is loaded or results imported, then the inserted nodes can be out of sync with the rest o the document.

To avoid this, the picking algorithm will need to allow for the picked nodes to have ChangeSettings() called on them during the ModifyDocument() call to ensure the inserted nodes are consistent with current document settings.

2014-01-08 08:19 Brendan MacLean
Milestone2.1»2.6

2014-04-14 16:02 Brendan MacLean
Milestone2.6»

2026-01-06 12:57 Brendan MacLean
resolve as GitHub Move
Statusopen»resolved
Skyline issues have moved to GitHub Issues at https://github.com/ProteoWizard/pwiz/issues
Issues will be ported as necessary for active work.

2026-01-06 12:58 Brendan MacLean
close
Statusresolved»closed
Assigned ToBrendan MacLean»Guest